Page MenuHomePhabricator

Remove BytesIO dependency from feature_dersig
ClosedPublic

Authored by jasonbcox on Feb 9 2019, 00:07.

Details

Summary

Cleanup

Test Plan

test_runner.py feature_dersig

Diff Detail

Repository
rABC Bitcoin ABC
Branch
dersig-fromhex
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4933
Build 7929: Bitcoin ABC Buildbot (legacy)
Build 7928: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Feb 9 2019, 08:59
Fabien added inline comments.
test/functional/feature_dersig.py
48

You can return directly and avoid the unused local variable

This revision now requires changes to proceed.Feb 9 2019, 08:59

Rebase + removed unnecessary intermediate variable

This revision is now accepted and ready to land.Feb 10 2019, 09:38
This revision was automatically updated to reflect the committed changes.