Page MenuHomePhabricator

Refactor TestNode arguments management
ClosedPublic

Authored by Fabien on Feb 10 2019, 11:15.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC3adc2efec6f1: Refactor TestNode arguments management
Summary

Refactor only, no functional change:

  • rename self.args to self.default_args
  • separate the binary name from the arguments list
  • add facilities to clear/add/remove default arguments
  • update test_framework and feature_config_args to use these facilities
Test Plan
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Feb 10 2019, 11:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 10 2019, 11:15
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox added inline comments.
test/functional/test_framework/test_framework.py
427 ↗(On Diff #7287)

I know you're making sure this is complete, but isn't this strictly unnecessary since the node was just init'd?

test/functional/test_framework/test_node.py
70 ↗(On Diff #7287)

Just a note for the future: Small one-liners like this should be put in their own diff. The hint is that the summary contains a list of semi-but-not-quite-related items.

jasonbcox added inline comments.Feb 11 2019, 18:48
test/functional/test_framework/test_framework.py
427 ↗(On Diff #7287)

Talked offline. This is needed due to the hardcoded args.

jasonbcox accepted this revision.Feb 11 2019, 18:48
This revision is now accepted and ready to land.Feb 11 2019, 18:48
This revision was automatically updated to reflect the committed changes.