Refactor only, no functional change:
- rename self.args to self.default_args
- separate the binary name from the arguments list
- add facilities to clear/add/remove default arguments
- update test_framework and feature_config_args to use these facilities
Details
Details
- Reviewers
deadalnix jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGING3adc2efec6f1: Refactor TestNode arguments management
rABC3adc2efec6f1: Refactor TestNode arguments management
./test/functional/test_runner.py
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- refactor_test_node_args
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4950 Build 7963: Bitcoin ABC Buildbot (legacy) Build 7962: arc lint + arc unit
Event Timeline
| test/functional/test_framework/test_framework.py | ||
|---|---|---|
| 427 | I know you're making sure this is complete, but isn't this strictly unnecessary since the node was just init'd? | |
| test/functional/test_framework/test_node.py | ||
| 70 | Just a note for the future: Small one-liners like this should be put in their own diff. The hint is that the summary contains a list of semi-but-not-quite-related items. | |
| test/functional/test_framework/test_framework.py | ||
|---|---|---|
| 427 | Talked offline. This is needed due to the hardcoded args. | |