Page MenuHomePhabricator
Differential D2613

Added functional test for estimatefee RPC
ClosedPublic
Actions

Authored by jasonbcox on Feb 26 2019, 19:20.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING8a165551eff6: Added functional test for estimatefee RPC
rABC8a165551eff6: Added functional test for estimatefee RPC
Summary

Need to test existing behavior in preparation for deprecating nblocks param.

Inspired by D2543

Test Plan

test_runner.py rpc_estimatefee

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Feb 26 2019, 19:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2019, 19:20
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 26 2019, 19:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox added a child revision: D2614: Remove unused param from txmempool::estimateFee.Feb 26 2019, 19:32
teamcity added a comment.Feb 26 2019, 19:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5077: Diff 7488.Feb 26 2019, 19:33
jasonbcox mentioned this in D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.Feb 26 2019, 19:50
jasonbcox edited the summary of this revision. (Show Details)
Fabien requested changes to this revision.Feb 28 2019, 07:31

Can you update timings.json in this diff, as you are adding a new test ?

This revision now requires changes to proceed.Feb 28 2019, 07:31
jasonbcox updated this revision to Diff 7561.Mar 1 2019, 21:00

Added new test timing

teamcity added a comment.Mar 1 2019, 21:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 1 2019, 21:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5120: Diff 7561.Mar 1 2019, 21:14
deadalnix accepted this revision.Mar 2 2019, 00:45
Fabien accepted this revision.Mar 4 2019, 18:00
Fabien added inline comments.
test/functional/rpc_estimatefee.py
6 ↗(On Diff #7561)

Please a blank line after this one

This revision is now accepted and ready to land.Mar 4 2019, 18:00
jasonbcox updated this revision to Diff 7572.Mar 4 2019, 18:45

Rebase + added separating line between imports

teamcity added a comment.Mar 4 2019, 18:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Closed by commit rABC8a165551eff6: Added functional test for estimatefee RPC (authored by jasonbcox). · Explain WhyMar 4 2019, 18:46
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Mar 4 2019, 18:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5127: Diff 7572.Mar 4 2019, 18:59
jasonbcox added a commit: rSTAGING8a165551eff6: Added functional test for estimatefee RPC.Sep 18 2019, 22:37

Revision Contents
Changeset List

PathSize
test/
functional/
33 lines
6 lines

Diff 7573

View Options

test/functional/rpc_estimatefee.py

Loading...
View Options

test/functional/timing.json

Loading...