Page MenuHomePhabricator

Added functional test for estimatefee RPC
ClosedPublic

Authored by jasonbcox on Feb 26 2019, 19:20.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rABC8a165551eff6: Added functional test for estimatefee RPC
Summary

Need to test existing behavior in preparation for deprecating nblocks param.

Inspired by D2543

Test Plan

test_runner.py rpc_estimatefee

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Feb 26 2019, 19:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2019, 19:20
Herald added a subscriber: schancel. · View Herald Transcript
Fabien requested changes to this revision.Feb 28 2019, 07:31

Can you update timings.json in this diff, as you are adding a new test ?

This revision now requires changes to proceed.Feb 28 2019, 07:31
jasonbcox updated this revision to Diff 7561.Mar 1 2019, 21:00

Added new test timing

deadalnix accepted this revision.Mar 2 2019, 00:45
Fabien accepted this revision.Mar 4 2019, 18:00
Fabien added inline comments.
test/functional/rpc_estimatefee.py
6 ↗(On Diff #7561)

Please a blank line after this one

This revision is now accepted and ready to land.Mar 4 2019, 18:00
jasonbcox updated this revision to Diff 7572.Mar 4 2019, 18:45

Rebase + added separating line between imports

This revision was automatically updated to reflect the committed changes.