Page MenuHomePhabricator

Added functional test for estimatefee RPC
ClosedPublic

Authored by jasonbcox on Feb 26 2019, 19:20.

Details

Summary

Need to test existing behavior in preparation for deprecating nblocks param.

Inspired by D2543

Test Plan

test_runner.py rpc_estimatefee

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D2613
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5120
Build 8303: Bitcoin ABC Buildbot (legacy)
Build 8302: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Feb 28 2019, 07:31

Can you update timings.json in this diff, as you are adding a new test ?

This revision now requires changes to proceed.Feb 28 2019, 07:31
Fabien added inline comments.
test/functional/rpc_estimatefee.py
6

Please a blank line after this one

This revision is now accepted and ready to land.Mar 4 2019, 18:00

Rebase + added separating line between imports

This revision was automatically updated to reflect the committed changes.