Page MenuHomePhabricator

Deprecate nblocks from estimatefee RPC
ClosedPublic

Authored by jasonbcox on Feb 26 2019, 19:48.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rABC6d9922049a87: Deprecate nblocks from estimatefee RPC
Summary

nblocks is no longer necessary, as the implementation does not use it.
Depends on D2614
Split out from D2543 for better review

Test Plan
ninja check
make check
test_runner.py rpc_estimatefee
bitcoind
bitcoin-cli estimatefee # succeeds
bitcoin-cli estimatefee 2 # errors as expected

bitcoind -deprecatedrpc=estimatefee
bitcoin-cli estimatefee # succeeds
bitcoin-cli estimatefee 2 # succeeds

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Feb 26 2019, 19:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2019, 19:48
Herald added a subscriber: schancel. · View Herald Transcript
Fabien accepted this revision.Feb 28 2019, 07:47

Maybe you can add a note somewhere in the help or in the release note to inform that the deprecation can be bypassed with the -deprecatedrpc=estimatefee option.

This revision is now accepted and ready to land.Feb 28 2019, 07:47
jasonbcox updated this revision to Diff 7638.Mar 7 2019, 18:37

Rebase + updated release notes comment

jasonbcox edited the test plan for this revision. (Show Details)Mar 7 2019, 18:44
jasonbcox edited the test plan for this revision. (Show Details)Mar 7 2019, 18:53
This revision was automatically updated to reflect the committed changes.