Page MenuHomePhabricator

Deprecate nblocks from estimatefee RPC
ClosedPublic

Authored by jasonbcox on Feb 26 2019, 19:48.

Details

Summary

nblocks is no longer necessary, as the implementation does not use it.
Depends on D2614
Split out from D2543 for better review

Test Plan
ninja check
make check
test_runner.py rpc_estimatefee
bitcoind
bitcoin-cli estimatefee # succeeds
bitcoin-cli estimatefee 2 # errors as expected

bitcoind -deprecatedrpc=estimatefee
bitcoin-cli estimatefee # succeeds
bitcoin-cli estimatefee 2 # succeeds

Diff Detail

Repository
rABC Bitcoin ABC
Branch
estimatefee-rpc
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5177
Build 8417: Bitcoin ABC Buildbot (legacy)
Build 8416: arc lint + arc unit

Event Timeline

Maybe you can add a note somewhere in the help or in the release note to inform that the deprecation can be bypassed with the -deprecatedrpc=estimatefee option.

This revision is now accepted and ready to land.Feb 28 2019, 07:47

Rebase + updated release notes comment

This revision was automatically updated to reflect the committed changes.