Deprecate nblocks from estimatefee RPC
ClosedPublic
Actions

Authored by jasonbcox on Feb 26 2019, 19:48.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING6d9922049a87: Deprecate nblocks from estimatefee RPC
rABC6d9922049a87: Deprecate nblocks from estimatefee RPC

Summary

nblocks is no longer necessary, as the implementation does not use it.
Depends on D2614
Split out from D2543 for better review

Test Plan

ninja check
make check
test_runner.py rpc_estimatefee

bitcoind
bitcoin-cli estimatefee # succeeds
bitcoin-cli estimatefee 2 # errors as expected

bitcoind -deprecatedrpc=estimatefee
bitcoin-cli estimatefee # succeeds
bitcoin-cli estimatefee 2 # succeeds

Diff Detail

Repository

rABC Bitcoin ABC

Branch

estimatefee-rpc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5080
Build 8223: Bitcoin ABC Buildbot (legacy)
Build 8222: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 26 2019, 19:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 26 2019, 19:48

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox mentioned this in D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.Feb 26 2019, 19:50

jasonbcox edited the summary of this revision. (Show Details)

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5080: Diff 7491.Feb 26 2019, 20:02

Maybe you can add a note somewhere in the help or in the release note to inform that the deprecation can be bypassed with the -deprecatedrpc=estimatefee option.

This revision is now accepted and ready to land.Feb 28 2019, 07:47

Rebase + updated release notes comment

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the test plan for this revision. (Show Details)Mar 7 2019, 18:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5177: Diff 7638.Mar 7 2019, 18:52

jasonbcox edited the test plan for this revision. (Show Details)Mar 7 2019, 18:53

Closed by commit rABC6d9922049a87: Deprecate nblocks from estimatefee RPC (authored by jasonbcox). · Explain WhyMar 7 2019, 19:01

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING6d9922049a87: Deprecate nblocks from estimatefee RPC.Sep 18 2019, 22:39