Confirmation targets do not affect tx fees, so having this on the UI is useless at best and confusing at worst. I'm also removing confirmation targets from txmempool::estimateFee's API in D2614, so there is no plan to use this in the future.
Details
Details
- Reviewers
deadalnix Fabien - Group Reviewers
Restricted Project - Commits
- rSTAGING43d3860f4c0b: Removed unused confirmation target dropdown from the UI
rABC43d3860f4c0b: Removed unused confirmation target dropdown from the UI
ninja check
test_runner.py
bitcoin-qt
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- uiconftarget
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5129 Build 8321: Bitcoin ABC Buildbot (legacy) Build 8320: arc lint + arc unit
Event Timeline
| src/qt/sendcoinsdialog.cpp | ||
|---|---|---|
| 258 ↗ | (On Diff #7571) | This block of code is no longer needed. // nSmartFeeSliderPosition and nConfTarget are obsolete.
// Remove them from the settings if they exist
if (settings.value("nSmartFeeSliderPosition").toInt() != 0) {
settings.remove("nSmartFeeSliderPosition");
}
if (settings.value("nConfTarget").toInt() != 0) {
settings.remove("nConfTarget");
} |
| src/qt/sendcoinsdialog.cpp | ||
|---|---|---|
| 258 ↗ | (On Diff #7571) | I agree. This should also be cleaned up in the next major version, so I've noted that in the comment. |