[rpc] getblockchaininfo: add size_on_disk, prune_target_size, automatic_pruning
AbandonedPublic
Actions

Authored by nakihito on Mar 23 2019, 00:00.

Details

Reviewers

jasonbcox
deadalnix
Fabien

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

Fix pruneheight help text.
Move fPruneMode block to match output ordering with help text.
Add functional tests for new fields in getblockchaininfo.

Backport of PR11367
https://github.com/bitcoin/bitcoin/pull/11367/

Completes T462

Dependent on D2730

Test Plan

make check
test_runner.py
getblockchaininfo should show "size_on_disk" and, when prune is on, "prune_target"

Diff Detail

Repository

rABC Bitcoin ABC

Branch

BackportPR11367

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5358
Build 8778: Bitcoin ABC Buildbot (legacy)
Build 8777: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 23 2019, 00:00

Owners added a reviewer: Restricted Owners Package.Mar 23 2019, 00:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 23 2019, 00:00

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5283: Diff 7804.Mar 23 2019, 00:16

nakihito abandoned this revision.Mar 23 2019, 01:16

Rebased off master.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito abandoned this revision.Apr 2 2019, 17:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5358: Diff 7911.Apr 2 2019, 17:57

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

1 line

src/

rpc/

blockchain.cpp

34 lines

validation.h

5 lines

validation.cpp

8 lines

test/

functional/

rpc_blockchain.py

33 lines

Diff 7911

View Options

doc/release-notes.md

View Options

src/rpc/blockchain.cpp

View Options

src/validation.h

View Options

src/validation.cpp

View Options

test/functional/rpc_blockchain.py

[rpc] getblockchaininfo: add size_on_disk, prune_target_size, automatic_pruningAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7911

doc/release-notes.md

src/rpc/blockchain.cpp

src/validation.h

src/validation.cpp

test/functional/rpc_blockchain.py

[rpc] getblockchaininfo: add size_on_disk, prune_target_size, automatic_pruning
AbandonedPublic
Actions

Revision Contents
Changeset List