Fix increment in rpc/mining.cpp when coinbase tx is skipped
ClosedPublic
Actions

Authored by jasonbcox on Apr 9 2019, 19:09.

Details

Reviewers

deadalnix
Fabien
schancel

Group Reviewers

Restricted Project

Commits

rSTAGINGf0c760c61323: Fix increment in rpc/mining.cpp when coinbase tx is skipped
rABCf0c760c61323: Fix increment in rpc/mining.cpp when coinbase tx is skipped

Summary

D2782 introduces an off-by-one error when fetching fees and sigopscount from pblocktemplate.

https://build.bitcoinabc.org/viewLog.html?buildId=12706&tab=buildResultsDiv&buildTypeId=BitcoinABCMasterLinux

Test Plan

make check
test_runner.py abc-magnetic-anomaly-mining

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fixmaster

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5426
Build 8914: Bitcoin ABC Buildbot (legacy)
Build 8913: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 9 2019, 19:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 9 2019, 19:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Apr 9 2019, 19:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5426: Diff 8019.Apr 9 2019, 19:25

Fabien accepted this revision.Apr 9 2019, 19:35

This revision is now accepted and ready to land.Apr 9 2019, 19:35

Closed by commit rABCf0c760c61323: Fix increment in rpc/mining.cpp when coinbase tx is skipped (authored by jasonbcox). · Explain WhyApr 9 2019, 19:39

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGINGf0c760c61323: Fix increment in rpc/mining.cpp when coinbase tx is skipped.Sep 18 2019, 22:56

Revision Contents
Changeset List

Path

Size

src/

rpc/

mining.cpp

1 line

Diff 8019

View Options

Fix increment in rpc/mining.cpp when coinbase tx is skippedClosedPublicActions