Page MenuHomePhabricator

[mining] Add fields for tracking package data.
Needs RevisionPublic

Authored by schancel on Apr 23 2019, 01:06.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Add additional fields to allow tracking package information

Depends on D2862, and D3162

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chains-for-real2 (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5569
Build 9200: Bitcoin ABC Buildbot (legacy)
Build 9199: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 23 2019, 01:06
schancel retitled this revision from Add fields for tracking package data. to [mining] Add fields for tracking package data..Apr 23 2019, 01:12

Change name of packageCount and add some explanatory comments

jasonbcox requested changes to this revision.Apr 24 2019, 23:05
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/miner.h
39

I have no sense of scale for this value. Is order == # of dependencies? If so, why not just call it pacakageDependencies?

41

The note is the only reference to double counting. There needs to be an explanation in this comment for this behavior otherwise the (>= real size) comments mean nothing without that context.

This revision now requires changes to proceed.Apr 24 2019, 23:05
src/miner.h
39

Also: There should be a comment in this diff or the summary with a link to the other diff where this is used so reviewers can appropriate evaluate it. Otherwise we're just looking at variable names with no context.

src/miner.h
39

There is a stack of all the diffs provided.

Rebase and fix a couple errors in the comments.

Update comment on the order field

src/miner.h
51 ↗(On Diff #8547)

packageOrder(1) should be packageOrder(0)

jasonbcox requested changes to this revision.May 9 2019, 20:55
jasonbcox added inline comments.
src/miner.h
51 ↗(On Diff #8547)

Fix this?

This revision now requires changes to proceed.May 9 2019, 20:55

packageOrder(1) -> packageOrder(0)

jasonbcox requested changes to this revision.Jun 21 2019, 22:00
This revision now requires changes to proceed.Jun 21 2019, 22:00