Page MenuHomePhabricator
Differential D2863

[mining] Add fields for tracking package data.
Needs RevisionPublic
Actions

Authored by schancel on Apr 23 2019, 01:06.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Add additional fields to allow tracking package information

Depends on D2862, and D3162

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chains-for-real2 (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5569
Build 9200: Bitcoin ABC Buildbot (legacy)
Build 9199: arc lint + arc unit

Event Timeline

schancel created this revision.Apr 23 2019, 01:06
Owners added a reviewer: Restricted Owners Package.Apr 23 2019, 01:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2019, 01:06
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Apr 23 2019, 01:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel retitled this revision from Add fields for tracking package data. to [mining] Add fields for tracking package data..Apr 23 2019, 01:12
schancel updated this revision to Diff 8226.Apr 23 2019, 01:15

Change name of packageCount and add some explanatory comments

schancel added a child revision: D2864: [mining] Add package accounting functions to CBlockTemplateEntry.Apr 23 2019, 01:17
teamcity added a comment.Apr 23 2019, 01:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 23 2019, 01:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5568: Diff 8225.Apr 23 2019, 01:20
Harbormaster completed remote builds in B5569: Diff 8226.Apr 23 2019, 01:32
teamcity added a comment.Apr 23 2019, 01:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox requested changes to this revision.Apr 24 2019, 23:05
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/miner.h
39

I have no sense of scale for this value. Is order == # of dependencies? If so, why not just call it pacakageDependencies?

41

The note is the only reference to double counting. There needs to be an explanation in this comment for this behavior otherwise the (>= real size) comments mean nothing without that context.

This revision now requires changes to proceed.Apr 24 2019, 23:05
jasonbcox added inline comments.Apr 24 2019, 23:07
src/miner.h
39

Also: There should be a comment in this diff or the summary with a link to the other diff where this is used so reviewers can appropriate evaluate it. Otherwise we're just looking at variable names with no context.

schancel added inline comments.Apr 25 2019, 05:54
src/miner.h
39

There is a stack of all the diffs provided.

schancel updated this revision to Diff 8545.May 9 2019, 02:20

Rebase and fix a couple errors in the comments.

teamcity added a comment.May 9 2019, 02:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel updated this revision to Diff 8547.May 9 2019, 02:22

Update comment on the order field

teamcity added a comment.May 9 2019, 02:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5776: Diff 8545.May 9 2019, 02:36
teamcity added a comment.May 9 2019, 02:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

teamcity added a comment.May 9 2019, 02:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5778: Diff 8547.May 9 2019, 02:37
schancel added inline comments.May 9 2019, 06:08
src/miner.h
51 ↗(On Diff #8547)

packageOrder(1) should be packageOrder(0)

jasonbcox requested changes to this revision.May 9 2019, 20:55
jasonbcox added inline comments.
src/miner.h
51 ↗(On Diff #8547)

Fix this?

This revision now requires changes to proceed.May 9 2019, 20:55
schancel updated this revision to Diff 8576.May 10 2019, 01:48

packageOrder(1) -> packageOrder(0)

teamcity added a comment.May 10 2019, 01:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 10 2019, 02:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5789: Diff 8576.May 10 2019, 02:03
schancel updated this revision to Diff 9025.May 31 2019, 03:32

Rebase on D3162

schancel edited the summary of this revision. (Show Details)May 31 2019, 03:32
schancel added a parent revision: D3162: [mining] Add a test for TestCBlockTemplateEntry.
teamcity added a comment.May 31 2019, 03:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 31 2019, 03:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6081: Diff 9025.May 31 2019, 03:47
jasonbcox requested changes to this revision.Jun 21 2019, 22:00
This revision now requires changes to proceed.Jun 21 2019, 22:00

Revision Contents
Changeset List

PathSize
src/
15 lines

Diff 8226

View Options

src/miner.h

Loading...