Page MenuHomePhabricator
Differential D2886

Remove direct bitcoin calls from qt/paymentserver.cpp
ClosedPublic
Actions

Authored by jasonbcox on Apr 29 2019, 17:00.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGca3673a14298: Remove direct bitcoin calls from qt/paymentserver.cpp
rABCca3673a14298: Remove direct bitcoin calls from qt/paymentserver.cpp
Summary

Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/3cab2ce5f9e159ad5a2e9ed682f28121b5248580
Progress towards T417
Depends on D2885

Test Plan

make check
ninja check
bitcoin-qt # sanity checks

Diff Detail

Repository
rABC Bitcoin ABC
Branch
paymentserver
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5630
Build 9322: Bitcoin ABC Buildbot (legacy)
Build 9321: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 29 2019, 17:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 29 2019, 17:00
teamcity added a comment.Apr 29 2019, 17:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5619: Diff 8298.Apr 29 2019, 17:15
teamcity added a comment.Apr 29 2019, 17:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox edited the summary of this revision. (Show Details)Apr 29 2019, 18:46
jasonbcox added a parent revision: D2885: Remove direct bitcoin calls from qt/addresstablemodel.cpp.
jasonbcox added a child revision: D2887: Remove direct bitcoin calls from qt transaction table files.Apr 29 2019, 18:46
Fabien requested changes to this revision.Apr 30 2019, 10:31
Fabien added inline comments.
src/qt/paymentserver.cpp
5 ↗(On Diff #8298)

<qt/paymentserver.h>

src/qt/paymentserver.h
31 ↗(On Diff #8298)

Nit: add a newline after this include. This prevents clang-format from sorting it.

This revision now requires changes to proceed.Apr 30 2019, 10:31
jasonbcox updated this revision to Diff 8311.Apr 30 2019, 16:17

Rebase + fix qt include

teamcity added a comment.Apr 30 2019, 16:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5630: Diff 8311.Apr 30 2019, 16:31
teamcity added a comment.Apr 30 2019, 16:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.May 1 2019, 11:09
This revision is now accepted and ready to land.May 1 2019, 11:09
Closed by commit rABCca3673a14298: Remove direct bitcoin calls from qt/paymentserver.cpp (authored by Russell Yanofsky <russ@yanofsky.org>, committed by jasonbcox). · Explain WhyMay 1 2019, 15:53
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGINGca3673a14298: Remove direct bitcoin calls from qt/paymentserver.cpp.Sep 18 2019, 23:10
PiRK mentioned this in D14730: wallet: Avoid locking cs_wallet recursively.Nov 3 2023, 09:03
PiRK mentioned this in rABC0cb1d1901233: wallet: Avoid locking cs_wallet recursively.Nov 3 2023, 14:40

Revision Contents
Changeset List

PathSize
src/
interfaces/
3 lines
1 line
16 lines
4 lines
qt/
13 lines
15 lines
56 lines
test/
2 lines
2 lines
2 lines

Diff 8311

View Options

src/interfaces/node.h

Loading...
View Options

src/interfaces/node.cpp

Loading...
View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/paymentserver.h

Loading...
View Options

src/qt/paymentserver.cpp

Loading...
View Options

src/qt/test/paymentservertests.cpp

Loading...
View Options

src/qt/walletmodel.h

Loading...
View Options

src/qt/walletmodel.cpp

Loading...