Page MenuHomePhabricator

Remove direct bitcoin calls from qt/paymentserver.cpp
ClosedPublic

Authored by jasonbcox on Apr 29 2019, 17:00.

Details

Summary
Test Plan

make check
ninja check
bitcoin-qt # sanity checks

Diff Detail

Repository
rABC Bitcoin ABC
Branch
paymentserver
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5630
Build 9322: Bitcoin ABC Buildbot (legacy)
Build 9321: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Apr 30 2019, 10:31
Fabien added inline comments.
src/qt/paymentserver.cpp
5 ↗(On Diff #8298)

<qt/paymentserver.h>

src/qt/paymentserver.h
31 ↗(On Diff #8298)

Nit: add a newline after this include. This prevents clang-format from sorting it.

This revision now requires changes to proceed.Apr 30 2019, 10:31
This revision is now accepted and ready to land.May 1 2019, 11:09
This revision was automatically updated to reflect the committed changes.