Page MenuHomePhabricator

Remove direct bitcoin calls from qt/sendcoinsdialog.cpp
ClosedPublic

Authored by jasonbcox on Apr 29 2019, 22:28.

Details

Summary
Test Plan

make check
ninja check
bitcoin-qt # sanity checks on send coins dialog

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sendcoins
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5622
Build 9306: Bitcoin ABC Buildbot (legacy)
Build 9305: arc lint + arc unit

Event Timeline

src/interfaces/node.h
159

Added to support the codepath for GetMinimumFee which doesn't use coin control.

169

This was removed in D2884 since ABC doesn't support smart fee. However, there appears to be some left over code. Rather than attempt to remove it entirely, I added it back as a stub that can be cleaned up later with the complete removal of smart fee.

src/interfaces/node.h
169

Is there some code still referencing smart fees outside of the qt labels ?

I understand that you need a wrapper, but what is the advantage in keeping the smart fee name if there is no smart fee anymore ? You can just call it estimateFee() and that would be less confusing IMO.

src/interfaces/node.h
169

No. We need to clean up estimateFee from the UI. The benefit of keeping the smartfee name here is that updateSmartFeeLabel() is the only caller, and it's not clear if it has any usefulness outside of that. When updateSmartFeeLabel() gets cleaned up, this can go with it.

Ok let this move forward and clean it later

This revision is now accepted and ready to land.May 2 2019, 05:57
This revision was automatically updated to reflect the committed changes.