Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/56f33ca349b3721a15fce3bf0b6d4fd7fd788970
Progress towards T417
Depends on D2888
Details
Details
- Reviewers
deadalnix Fabien - Group Reviewers
Restricted Project - Commits
- rSTAGINGe63967b50b8e: Remove direct bitcoin calls from qt/sendcoinsdialog.cpp
rABCe63967b50b8e: Remove direct bitcoin calls from qt/sendcoinsdialog.cpp
make check
ninja check
bitcoin-qt # sanity checks on send coins dialog
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- sendcoins
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5638 Build 9338: Bitcoin ABC Buildbot (legacy) Build 9337: arc lint + arc unit
Event Timeline
| src/interfaces/node.h | ||
|---|---|---|
| 159 ↗ | (On Diff #8301) | Added to support the codepath for GetMinimumFee which doesn't use coin control. |
| 169 ↗ | (On Diff #8301) | This was removed in D2884 since ABC doesn't support smart fee. However, there appears to be some left over code. Rather than attempt to remove it entirely, I added it back as a stub that can be cleaned up later with the complete removal of smart fee. |
| src/interfaces/node.h | ||
|---|---|---|
| 169 ↗ | (On Diff #8301) | Is there some code still referencing smart fees outside of the qt labels ? I understand that you need a wrapper, but what is the advantage in keeping the smart fee name if there is no smart fee anymore ? You can just call it estimateFee() and that would be less confusing IMO. |
| src/interfaces/node.h | ||
|---|---|---|
| 169 ↗ | (On Diff #8301) | No. We need to clean up estimateFee from the UI. The benefit of keeping the smartfee name here is that updateSmartFeeLabel() is the only caller, and it's not clear if it has any usefulness outside of that. When updateSmartFeeLabel() gets cleaned up, this can go with it. |