Simplify CConnman::SocketSendData routine.
ClosedPublic
Actions

Authored by deadalnix on Jun 28 2017, 17:50.

Details

Reviewers

freetrader
sickpig
kyuupichan
awemany

Group Reviewers

Restricted Project

Commits

rSTAGING075e9948e7ec: Simplify CConnman::SocketSendData routine.
rABC075e9948e7ec: Simplify CConnman::SocketSendData routine.

Summary

As per title. The orginial logic is very convoluted. used this simplification to debug D284 .

Test Plan

make check
../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fixtstbuf

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 449
Build 449: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 28 2017, 17:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 28 2017, 17:50

Harbormaster completed remote builds in B439: Diff 714.Jun 28 2017, 17:50

I do not have any issue with this change, but the Test Plan is inadequate since there are no unit tests covering this, hence 'make check' does not test it - it requires running at least the Python tests.

Please change the Test Plan to include a full run of the regression test suite.

I ran the changes on top of b6ba0d06bf , and it passed the extended suite on my setup. Therefore I don't think there significant risk of regression here.

This revision now requires changes to proceed.Jun 29 2017, 06:21