Page MenuHomePhabricator

Simplify CConnman::SocketSendData routine.
ClosedPublic

Authored by deadalnix on Jun 28 2017, 17:50.

Details

Summary

As per title. The orginial logic is very convoluted. used this simplification to debug D284 .

Test Plan
make check
../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fixtstbuf
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 439
Build 439: arc lint + arc unit

Event Timeline

freetrader requested changes to this revision.EditedJun 29 2017, 06:21

I do not have any issue with this change, but the Test Plan is inadequate since there are no unit tests covering this, hence 'make check' does not test it - it requires running at least the Python tests.

Please change the Test Plan to include a full run of the regression test suite.

I ran the changes on top of b6ba0d06bf , and it passed the extended suite on my setup. Therefore I don't think there significant risk of regression here.

This revision now requires changes to proceed.Jun 29 2017, 06:21
deadalnix edited edge metadata.

Rebase and run the extended test suite.

freetrader requested changes to this revision.Jul 3 2017, 12:35

Please update the TEST PLAN , that was the point of my initial request.

This revision now requires changes to proceed.Jul 3 2017, 12:35
deadalnix edited the test plan for this revision. (Show Details)
deadalnix edited edge metadata.

Updated test plan.

This revision is now accepted and ready to land.Jul 3 2017, 13:39
This revision was automatically updated to reflect the committed changes.