Page MenuHomePhabricator
Differential D2957

Merge #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished
ClosedPublic
Actions

Authored by jasonbcox on May 7 2019, 00:37.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING007edfcb94b1: Merge #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is…
rABC007edfcb94b1: Merge #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is…
Summary

cb1e319 Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished (Jorge Timón)

Pull request description:

Fixes https://github.com/bitcoin/bitcoin/issues/12142

The tests are a little bit slow, mempool_persist.py goes from about 20 s to about 120 s in my hardware.
Perhaps there's a better way to test this.

Tree-SHA512: 9e6c24b32a9cf3774e8f0bd81c035b0deb53fba5ac3eb2532d85900579d21cef8a1135b75a4fa0a9d883e3822eb35e7d4b47a0838abf99789039205041962629

Backport of Core PR 12172
https://github.com/bitcoin/bitcoin/pull/12172/files
Depends on D2946

Test Plan

make check
test_runner.py mempool_persist

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12172
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5716
Build 9494: Bitcoin ABC Buildbot (legacy)
Build 9493: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 7 2019, 00:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2019, 00:37
teamcity added a comment.May 7 2019, 00:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)May 7 2019, 00:37
jasonbcox added a parent revision: D2946: Merge #11099: [RPC][mempool]: Add savemempool RPC.
Harbormaster completed remote builds in B5716: Diff 8444.May 7 2019, 00:51
teamcity added a comment.May 7 2019, 00:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien mentioned this in D2946: Merge #11099: [RPC][mempool]: Add savemempool RPC.May 7 2019, 07:57
Fabien accepted this revision.May 8 2019, 10:03
This revision is now accepted and ready to land.May 8 2019, 10:03
Closed by commit rABC007edfcb94b1: Merge #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMay 8 2019, 18:25
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING007edfcb94b1: Merge #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is….Sep 18 2019, 23:22

Revision Contents
Changeset List

PathSize
src/
5 lines
rpc/
7 lines
1 line
1 line

Diff 8444

View Options

src/init.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...