Page MenuHomePhabricator
Differential D2995

Merge #12842: Prevent concurrent savemempool
ClosedPublic
Actions

Authored by jasonbcox on May 8 2019, 18:36.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING90e16b238720: Merge #12842: Prevent concurrent savemempool
rABC90e16b238720: Merge #12842: Prevent concurrent savemempool
Summary

585b47cfe133fae112782ad0a88fe25c71d465fa rpc: Prevent concurrent savemempool (João Barbosa)

Pull request description:

Follow up of #12172, this change prevents calling `savemempool` RPC concurrently.

Tree-SHA512: 4759a7107658a9794f5c6ab7e3e3002276abadd64996010be67a2791914d284db6fe0377c071a8d6a42387bfb0178f219b73aeec077ce5c4fe5c634a30b3e081

Backport of Core PR12842
https://github.com/bitcoin/bitcoin/pull/12842/files
Depends on D2946, D2996

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12842
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5759
Build 9580: Bitcoin ABC Buildbot (legacy)
Build 9579: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 8 2019, 18:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 8 2019, 18:36
teamcity added a comment.May 8 2019, 18:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B5759: Diff 8519!May 8 2019, 18:40
teamcity added a comment.May 8 2019, 18:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

jasonbcox planned changes to this revision.May 8 2019, 18:45
jasonbcox updated this revision to Diff 8524.May 8 2019, 19:20

Rebase on D2996

jasonbcox edited the summary of this revision. (Show Details)May 8 2019, 19:20
jasonbcox added a parent revision: D2996: Merge #11599: scripted-diff: Small locking rename.
teamcity added a comment.May 8 2019, 19:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5763: Diff 8524.May 8 2019, 19:35
teamcity added a comment.May 8 2019, 19:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox edited the summary of this revision. (Show Details)May 9 2019, 00:16
Fabien accepted this revision.May 9 2019, 06:21
This revision is now accepted and ready to land.May 9 2019, 06:21
Closed by commit rABC90e16b238720: Merge #12842: Prevent concurrent savemempool (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMay 9 2019, 16:59
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING90e16b238720: Merge #12842: Prevent concurrent savemempool.Sep 18 2019, 23:26

Revision Contents
Changeset List

PathSize
src/
3 lines

Diff 8519

View Options

src/validation.cpp

Loading...