Page MenuHomePhabricator
Differential D3019

[CMAKE] Add cross build toolchain files for PC Linux platform
ClosedPublic
Actions

Authored by Fabien on May 10 2019, 14:18.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGa6d4a5e5d4a9: [CMAKE] Add cross build toolchain files for PC Linux platform
rABCa6d4a5e5d4a9: [CMAKE] Add cross build toolchain files for PC Linux platform
Summary

This allows to use the depends system for building a deterministic linux
binary.

Depends on D3017

Test Plan

Note: see dependencies in contrib/gitian-descriptors/gitian-linus.yml

mkdir buildcmake && cd buildcmake
cmake -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake \
-GNinja ..
ninja

Run src/bitcoind and src/qt/bitcoin-qt on a 64 bits Linux

rm -rf *
cmake -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux32.cmake \
-GNinja ..
ninja

Run src/bitcoind and src/qt/bitcoin-qt on a 32 bits Linux

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_linux32
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5802
Build 9666: Bitcoin ABC Buildbot (legacy)
Build 9665: arc lint + arc unit

Event Timeline

Fabien created this revision.May 10 2019, 14:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 10 2019, 14:18
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 10 2019, 14:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 10 2019, 14:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5802: Diff 8595.May 10 2019, 14:34
deadalnix requested changes to this revision.May 12 2019, 23:26

It's not clear that this depends on any way on the diff you say it depends on.

cmake/platforms/Linux32.cmake
29

Same as for 64 bits

cmake/platforms/Linux64.cmake
26

One line

29

It does seems like the extra variable is not making this any simpler, is it.

This revision now requires changes to proceed.May 12 2019, 23:26
Fabien updated this revision to Diff 8623.May 13 2019, 09:11

Remove extra variable.

Fabien added a comment.May 13 2019, 09:11

The dependency is only required for the test plan to pass.

teamcity added a comment.May 13 2019, 09:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5823: Diff 8623.May 13 2019, 09:25
teamcity added a comment.May 13 2019, 09:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.May 16 2019, 23:09
This revision is now accepted and ready to land.May 16 2019, 23:09
Closed by commit rABCa6d4a5e5d4a9: [CMAKE] Add cross build toolchain files for PC Linux platform (authored by Fabien). · Explain WhyMay 25 2019, 07:17
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa6d4a5e5d4a9: [CMAKE] Add cross build toolchain files for PC Linux platform.
Fabien added a commit: rSTAGINGa6d4a5e5d4a9: [CMAKE] Add cross build toolchain files for PC Linux platform.Sep 18 2019, 23:45

Revision Contents
Changeset List

PathSize
cmake/
platforms/
29 lines
29 lines

Diff 8595

View Options

cmake/platforms/Linux32.cmake

Loading...
View Options

cmake/platforms/Linux64.cmake

Loading...