Page MenuHomePhabricator

Merge #10267: New -includeconf argument for including external configuration files
AbandonedPublic

Authored by markblundeberg on May 11 2019, 23:43.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T541: Backport Core PR10267 to support includeconf
Summary

backport PR10267 https://github.com/bitcoin/bitcoin/pull/10267/files
25b7ab9 doc: Add release notes for -includeconf (Karl-Johan Alm)
0f0badd test: Test includeconf parameter. (Karl-Johan Alm)
629ff8c -includeconf=<path> support in config handler, for including external configuration files (Karl-Johan Alm)

Pull request description:

Fixes: #10071.

Done:
- adds `-includeconf=<path>`, where `<path>` is relative to `datadir` or to the path of the file being read, if in a file
- protects against circular includes
- updates help docs

~~~Thoughts:~~~
- ~~~I am not sure how to test this in a neat manner. Feedback on this would be nice. Will dig/think though.~~~

Tree-SHA512: cb31f1b2f69fbc0890d264948eb2e501ac05cf12f5e06a5942f9c1539eb15ea8dc3cae817f4073aecb2fcc21d0386747f14f89d990772003a76e2a6d25642553

Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5816
Build 9694: Bitcoin ABC Teamcity Staging
Build 9693: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 11 2019, 23:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2019, 23:43

Note 13197 should be backported fairly soon too (T650)

doc/release-notes-pr10267.md
1 ↗(On Diff #8612)

oops, need to move this into regular release-notes

markblundeberg planned changes to this revision.May 11 2019, 23:55

move release notes into main doc

Fabien requested changes to this revision.May 14 2019, 11:53

Clearing my queue, see D3035

This revision now requires changes to proceed.May 14 2019, 11:53
markblundeberg abandoned this revision.May 14 2019, 15:01
In D3026#71602, @Fabien wrote:

Clearing my queue, see D3035

Well land it already then ! =D