Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

Delete accuratelyAddPackageTxns and the associated helper functions and types. These are no longer needed due to new implementation of addPackageTxns in D2866.

Depends on D2866

Test Plan

make -j16 check && ./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chains-for-real6 (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5817
Build 9696: Bitcoin ABC Buildbot (legacy)
Build 9695: arc lint + arc unit

Event Timeline

schancel created this revision.May 12 2019, 02:56

Owners added a reviewer: Restricted Owners Package.May 12 2019, 02:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2019, 02:56

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5817: Diff 8614.May 12 2019, 03:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

schancel edited the summary of this revision. (Show Details)May 12 2019, 06:27

schancel added a child revision: D3028: [mempool] remove `CompareTxMemPoolEntryByAncestorFee` as it is no longer needed.May 31 2019, 06:16

jasonbcox requested changes to this revision.Jun 21 2019, 22:01

This revision now requires changes to proceed.Jun 21 2019, 22:01

[mining] Delete accuratelyAddPackageTxns and its associates
Needs RevisionPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 8614

src/miner.h

src/miner.cpp

[mining] Delete accuratelyAddPackageTxns and its associatesNeeds RevisionPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8614

src/miner.h

src/miner.cpp

[mining] Delete accuratelyAddPackageTxns and its associates
Needs RevisionPublic
Actions

Revision Contents
Changeset List