Paths

Table of Contentst

[mempool] remove `CompareTxMemPoolEntryByAncestorFee` as it is no longer needed
Needs RevisionPublic
Actions

Authored by schancel on May 12 2019, 05:34.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

Delete CompareTxMemPoolEntryByAncestorFee and the associated mapTx index ancestor_score.
This is no longer needed, as we have implemented new mining code which does not depend on
these calcuations.

Depends on D3027

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chains-for-real7 (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5818
Build 9698: Bitcoin ABC Buildbot (legacy)
Build 9697: arc lint + arc unit

Event Timeline

schancel created this revision.May 12 2019, 05:34

Owners added a reviewer: Restricted Owners Package.May 12 2019, 05:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2019, 05:34

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5818: Diff 8615.May 12 2019, 05:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

schancel edited the summary of this revision. (Show Details)May 31 2019, 06:16

schancel added a parent revision: D3027: [mining] Delete accuratelyAddPackageTxns and its associates.

schancel removed a parent revision: D2866: [mining] Implement new package selection code which is independent of chain length.

jasonbcox requested changes to this revision.Jun 21 2019, 22:01

This revision now requires changes to proceed.Jun 21 2019, 22:01

Revision Contents
Changeset List

Path

Size

src/

test/

mempool_tests.cpp

121 lines

txmempool.h

27 lines

Diff 8615

View Options

src/test/mempool_tests.cpp