Merge #10431: Prevent shadowing the global dustRelayFee
ClosedPublic
Actions

Authored by nakihito on May 14 2019, 01:46.

Details

Reviewers

deadalnix
Fabien
jasonbcox
markblundeberg

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

43c5877 Prevent shadowing the global dustRelayFee. (Pavel Janík)

Tree-SHA512: 9765931a7753c484990003396afd0bb65a53f42d1cad9502017720618ce90b3c5ae68591db01e3524adecdbe6925a5eeeebf04012ba644ef3b65073af207ae5d

Backport of Core PR10431
https://github.com/bitcoin/bitcoin/pull/10431/

Depends on D3039

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR10431

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5841
Build 9744: Bitcoin ABC Buildbot (legacy)
Build 9743: arc lint + arc unit

Event Timeline

nakihito created this revision.May 14 2019, 01:46

Owners added a reviewer: Restricted Owners Package.May 14 2019, 01:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2019, 01:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

The warnings core had don't actually occur in our code base because of some other changes made before (we don't need to use the global dustRelayFee). However, renaming the arguments should help to prevent some confusion and will hopefully keep merge conflicts in future backports to a minimum.

Harbormaster completed remote builds in B5841: Diff 8648.May 14 2019, 02:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

I get the warnings, which compiler do you use ?

This revision is now accepted and ready to land.May 14 2019, 09:56