Page MenuHomePhabricator

Consensus: Minimal way to move dust out of consensus
Needs ReviewPublic

Authored by nakihito on Tue, May 14, 01:32.

Details

Reviewers
deadalnix
jasonbcox
Fabien
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary
Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR9278
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5884
Build 9828: Bitcoin ABC Teamcity Staging
Build 9827: arc lint + arc unit

Event Timeline

nakihito created this revision.Tue, May 14, 01:32
Owners added a reviewer: Restricted Owners Package.Tue, May 14, 01:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, May 14, 01:32
nakihito edited the test plan for this revision. (Show Details)Tue, May 14, 01:49

This is actually 1/2 commits, but the second one doesn't seem very applicable because of changes made in the past: https://reviews.bitcoinabc.org/rABC87d967d48f2702d8f7972a1b43ddae0054640836

Fabien requested changes to this revision.Tue, May 14, 09:50
Fabien added inline comments.
src/policy/policy.cpp
29 ↗(On Diff #8647)

Can you update the comments to remove the segwit references ?
Also please keep the previous formatting style /**/.

This revision now requires changes to proceed.Tue, May 14, 09:50
nakihito updated this revision to Diff 8665.Tue, May 14, 22:32

Fixed comment formatting and removed references to segwit.

Fabien requested changes to this revision.Thu, May 16, 15:27
Fabien added inline comments.
src/policy/policy.cpp
19 ↗(On Diff #8665)

Something gets wrong here. You can set all on a single line and lint to let clang-format create the line breaks.

This revision now requires changes to proceed.Thu, May 16, 15:27
nakihito updated this revision to Diff 8715.Fri, May 17, 17:27

Used linter to split up Dust comment.