Page MenuHomePhabricator

Consensus: Minimal way to move dust out of consensus
ClosedPublic

Authored by nakihito on May 14 2019, 01:32.

Details

Summary
Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR9278
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5853
Build 9766: Bitcoin ABC Teamcity Staging
Build 9765: arc lint + arc unit

Event Timeline

nakihito created this revision.May 14 2019, 01:32
Owners added a reviewer: Restricted Owners Package.May 14 2019, 01:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2019, 01:32
nakihito edited the test plan for this revision. (Show Details)May 14 2019, 01:49

This is actually 1/2 commits, but the second one doesn't seem very applicable because of changes made in the past: https://reviews.bitcoinabc.org/rABC87d967d48f2702d8f7972a1b43ddae0054640836

Fabien requested changes to this revision.May 14 2019, 09:50
Fabien added inline comments.
src/policy/policy.cpp
29 ↗(On Diff #8647)

Can you update the comments to remove the segwit references ?
Also please keep the previous formatting style /**/.

This revision now requires changes to proceed.May 14 2019, 09:50
nakihito updated this revision to Diff 8665.May 14 2019, 22:32

Fixed comment formatting and removed references to segwit.

Fabien requested changes to this revision.May 16 2019, 15:27
Fabien added inline comments.
src/policy/policy.cpp
19

Something gets wrong here. You can set all on a single line and lint to let clang-format create the line breaks.

This revision now requires changes to proceed.May 16 2019, 15:27
nakihito updated this revision to Diff 8715.May 17 2019, 17:27

Used linter to split up Dust comment.

Fabien accepted this revision.May 20 2019, 07:33
This revision is now accepted and ready to land.May 20 2019, 07:33
This revision was automatically updated to reflect the committed changes.
nakihito edited the summary of this revision. (Show Details)May 20 2019, 23:52
This revision was automatically updated to reflect the committed changes.