Paths

Table of Contentst

Differential D3039

Consensus: Minimal way to move dust out of consensus
ClosedPublic
Actions

Authored by nakihito on May 14 2019, 01:32.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
jasonbcox
Fabien
markblundeberg

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGa83e457a8f15: Consensus: Minimal way to move dust out of consensus
rSTAGING7cb2307fdf8d: Consensus: Minimal way to move dust out of consensus
rABCa83e457a8f15: Consensus: Minimal way to move dust out of consensus
rABC7cb2307fdf8d: Consensus: Minimal way to move dust out of consensus

Summary

Backport of Core PR9279
https://github.com/bitcoin/bitcoin/pull/9279

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.May 14 2019, 01:32

Owners added a reviewer: Restricted Owners Package.May 14 2019, 01:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2019, 01:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

nakihito added a child revision: D3040: Merge #10431: Prevent shadowing the global dustRelayFee.May 14 2019, 01:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5840: Diff 8647.May 14 2019, 01:47

nakihito edited the test plan for this revision. (Show Details)May 14 2019, 01:49

This is actually 1/2 commits, but the second one doesn't seem very applicable because of changes made in the past: https://reviews.bitcoinabc.org/rABC87d967d48f2702d8f7972a1b43ddae0054640836

Fabien requested changes to this revision.May 14 2019, 09:50

Fabien added inline comments.

src/policy/policy.cpp
29 ↗	(On Diff #8647)	Can you update the comments to remove the segwit references ? Also please keep the previous formatting style `/**/`.

This revision now requires changes to proceed.May 14 2019, 09:50

nakihito mentioned this in D3040: Merge #10431: Prevent shadowing the global dustRelayFee.May 14 2019, 17:44

Fixed comment formatting and removed references to segwit.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5853: Diff 8665.May 14 2019, 22:46

Fabien requested changes to this revision.May 16 2019, 15:27

Fabien added inline comments.

src/policy/policy.cpp
19 ↗	(On Diff #8665)	Something gets wrong here. You can set all on a single line and lint to let clang-format create the line breaks.

This revision now requires changes to proceed.May 16 2019, 15:27

Used linter to split up Dust comment.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5884: Diff 8715.May 17 2019, 17:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.May 20 2019, 07:33

This revision is now accepted and ready to land.May 20 2019, 07:33

Closed by commit rABC7cb2307fdf8d: Consensus: Minimal way to move dust out of consensus (authored by Jorge Timón <jtimon@jtimon.cc>, committed by nakihito). · Explain WhyMay 20 2019, 21:34

This revision was automatically updated to reflect the committed changes.

nakihito edited the summary of this revision. (Show Details)May 20 2019, 23:52

This revision was automatically updated to reflect the committed changes.May 22 2019, 00:14

Nico Guiton <nico@bitframe.org> added a commit: rABCa83e457a8f15: Consensus: Minimal way to move dust out of consensus.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING7cb2307fdf8d: Consensus: Minimal way to move dust out of consensus.Sep 18 2019, 23:37

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGa83e457a8f15: Consensus: Minimal way to move dust out of consensus.Sep 18 2019, 23:40

Revision Contents
Changeset List

Path

Size

src/

policy/

8 lines

Diff 8793

src/policy/policy.cpp

Loading...