Page MenuHomePhabricator

Consensus: Minimal way to move dust out of consensus
ClosedPublic

Authored by nakihito on May 14 2019, 01:32.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR9278
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5884
Build 9828: Bitcoin ABC Buildbot (legacy)
Build 9827: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.May 14 2019, 01:32

This is actually 1/2 commits, but the second one doesn't seem very applicable because of changes made in the past: https://reviews.bitcoinabc.org/rABC87d967d48f2702d8f7972a1b43ddae0054640836

Fabien requested changes to this revision.May 14 2019, 09:50
Fabien added inline comments.
src/policy/policy.cpp
29 ↗(On Diff #8647)

Can you update the comments to remove the segwit references ?
Also please keep the previous formatting style /**/.

This revision now requires changes to proceed.May 14 2019, 09:50

Fixed comment formatting and removed references to segwit.

Fabien requested changes to this revision.May 16 2019, 15:27
Fabien added inline comments.
src/policy/policy.cpp
19 ↗(On Diff #8665)

Something gets wrong here. You can set all on a single line and lint to let clang-format create the line breaks.

This revision now requires changes to proceed.May 16 2019, 15:27

Used linter to split up Dust comment.

This revision is now accepted and ready to land.May 20 2019, 07:33
This revision was automatically updated to reflect the committed changes.