Page MenuHomePhabricator

Merge #12333: Make CWallet::ListCoins atomic
Needs ReviewPublic

Authored by nakihito on Wed, May 15, 00:32.

Details

Reviewers
jasonbcox
deadalnix
Fabien
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

2f960b5 [wallet] Indent only change of CWallet::AvailableCoins (João Barbosa)
1beea7a [wallet] Make CWallet::ListCoins atomic (João Barbosa)

Pull request description:

Fix a potencial race in `CWallet::ListCoins`.

Replaces `cs_main` and `cs_wallet` locks by assertions in `CWallet::AvailableCoins`.

Tree-SHA512: 09109f44a08b4b53f7605d950ab506d3f748490ab9aed474aa200e93f7b0b9f96f9bf60abe1c5f658240fd13d9e3267c0dd43fd3c1695d82384198ce1da8109f

Backport of Core PR12333
https://github.com/bitcoin/bitcoin/pull/12333/

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12333
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5857
Build 9774: Bitcoin ABC Teamcity Staging
Build 9773: arc lint + arc unit

Event Timeline

nakihito created this revision.Wed, May 15, 00:32
Owners added a reviewer: Restricted Owners Package.Wed, May 15, 00:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, May 15, 00:32