Page MenuHomePhabricator
Differential D3071

Merge #12278: Add special error for genesis coinbase to getrawtransaction
ClosedPublic
Actions

Authored by markblundeberg on May 20 2019, 06:47.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING8f90b867e96b: Merge #12278: Add special error for genesis coinbase to getrawtransaction
rABC8f90b867e96b: Merge #12278: Add special error for genesis coinbase to getrawtransaction
Summary

PR12278 backport https://github.com/bitcoin/bitcoin/pull/12278/files
ee11121 Add special error for genesis coinbase to gettransaction (MeshCollider)

Pull request description:

Suggested by sipa here: https://botbot.me/freenode/bitcoin-core-dev/2018-01-23/?msg=96069825&page=2

Just adds a special error message for the genesis block coinbase transaction when using `getrawtransaction`
Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nogenesis
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5897
Build 9854: Bitcoin ABC Buildbot (legacy)
Build 9853: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 20 2019, 06:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2019, 06:47
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 20 2019, 06:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5897: Diff 8735.May 20 2019, 07:02
teamcity added a comment.May 20 2019, 07:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.May 20 2019, 08:49
This revision is now accepted and ready to land.May 20 2019, 08:49
Closed by commit rABC8f90b867e96b: Merge #12278: Add special error for genesis coinbase to getrawtransaction (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 20 2019, 14:00
This revision was automatically updated to reflect the committed changes.
markblundeberg mentioned this in D3072: Merge #11877: Improve createrawtransaction functional tests.May 20 2019, 14:02
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING8f90b867e96b: Merge #12278: Add special error for genesis coinbase to getrawtransaction.Sep 18 2019, 23:36

Revision Contents
Changeset List

PathSize
src/
rpc/
7 lines
test/
functional/
5 lines

Diff 8735

View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

test/functional/rpc_rawtransaction.py

Loading...