Merge #12468: Add missing newline in init.cpp log message
ClosedPublic
Actions

Authored by markblundeberg on May 24 2019, 22:22.

Details

Reviewers

jasonbcox
Fabien
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGc78697d04dfb: Merge #12468: Add missing newline in init.cpp log message
rABCc78697d04dfb: Merge #12468: Add missing newline in init.cpp log message

Summary

PR12468 backport https://github.com/bitcoin/bitcoin/pull/12468/files
8b661f971 fixes #12465 added missing terminating newline character in log message (Josh Hartshorn)

Pull request description:

Adding missing new line as detailed in #12465

Test Plan

make check

manually ran with pruning on testnet then re-ran with checkblocks=500; confirm that logs look better now

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12465

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5979
Build 10017: Bitcoin ABC Buildbot (legacy)
Build 10016: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 24 2019, 22:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 24 2019, 22:22

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5979: Diff 8863.May 24 2019, 22:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.May 24 2019, 23:03

This revision is now accepted and ready to land.May 24 2019, 23:03

Closed by commit rABCc78697d04dfb: Merge #12468: Add missing newline in init.cpp log message (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 24 2019, 23:09

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCc78697d04dfb: Merge #12468: Add missing newline in init.cpp log message.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGc78697d04dfb: Merge #12468: Add missing newline in init.cpp log message.Sep 18 2019, 23:44

Revision Contents
Changeset List

Path

Size

src/

init.cpp

8 lines

Diff 8863

View Options

Merge #12468: Add missing newline in init.cpp log messageClosedPublicActions