Page MenuHomePhabricator

De-witnessing some comments
ClosedPublic

Authored by markblundeberg on May 25 2019, 18:39.

Details

Summary

Catches some comments that referenced segwit.

Test Plan

read

Diff Detail

Repository
rABC Bitcoin ABC
Branch
witness
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5986
Build 10031: Bitcoin ABC Buildbot (legacy)
Build 10030: arc lint + arc unit

Event Timeline

markblundeberg retitled this revision from Some de-witnessing to De-witnessing some comments and RPC helptext.May 25 2019, 18:39

(Obviously if we ever introduce new tx format with scriptsig data redacted from txid calc, then we may have txid != hash. But that's a long long way off)

deadalnix requested changes to this revision.May 26 2019, 18:19
deadalnix added inline comments.
src/rpc/mining.cpp
389

We kept the distinction between txid and hash to make sure we can fix malleability. The fact it happen to be the same right now doesn't convey the semantic.

src/rpc/rawtransaction.cpp
108

dito

573

dito

This revision now requires changes to proceed.May 26 2019, 18:19
src/rpc/mining.cpp
389

Hmm what would you put then? The current text is no good as it mentions witness data.

markblundeberg retitled this revision from De-witnessing some comments and RPC helptext to De-witnessing some comments.
markblundeberg edited the summary of this revision. (Show Details)

reduce scope (remove RPC changes, restore a comment)

deadalnix added inline comments.
src/validation.cpp
1216 ↗(On Diff #9538)

Just tx hash. When that's not the case, we refers it as txid. Even though both are effectively the same value at the moment, they don't have to be going forward.

This revision is now accepted and ready to land.Jun 20 2019, 23:55