Page MenuHomePhabricator

Merge #10536: Remove unreachable or otherwise redundant code

Authored by nakihito on Jun 10 2019, 19:36.



4265bf351 Remove unreachable or otherwise redundant code (practicalswift)

Tree-SHA512: bc9666ab5d20c936d78c50c0361405aca9edd116602aa9bcd71a79a904b647ac9eca0651d1a9d530189a6ac1c4e235bfc69ec1a68f7e36cc14d6848ac2206b7b

Backport of Core PR10536

Test Plan
make check

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Jun 10 2019, 19:36
Owners added a reviewer: Restricted Owners Package.Jun 10 2019, 19:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 10 2019, 19:36
nakihito planned changes to this revision.Jun 10 2019, 20:56
nakihito requested review of this revision.EditedJun 10 2019, 22:39

Changes to bitcoin-tx.cpp removed here:

Changes to wallet/rpcnestedtests.cpp removed here:

wallet/crypter.cpp changes removed here:

wallet/rpcwallet.cpp changes are removed here:

Changes to wallet/walletdb.cpp are removed here: Edit: the would-be-removed line is now used in the very next line

jasonbcox accepted this revision.Jun 10 2019, 22:56
This revision is now accepted and ready to land.Jun 10 2019, 22:56