Page MenuHomePhabricator
Differential D3278

Merge #10536: Remove unreachable or otherwise redundant code
ClosedPublic
Actions

Authored by nakihito on Jun 10 2019, 19:36.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGdfc1e4deffce: Merge #10536: Remove unreachable or otherwise redundant code
rABCdfc1e4deffce: Merge #10536: Remove unreachable or otherwise redundant code
Summary

4265bf351 Remove unreachable or otherwise redundant code (practicalswift)

Tree-SHA512: bc9666ab5d20c936d78c50c0361405aca9edd116602aa9bcd71a79a904b647ac9eca0651d1a9d530189a6ac1c4e235bfc69ec1a68f7e36cc14d6848ac2206b7b

Backport of Core PR10536
https://github.com/bitcoin/bitcoin/pull/10536/files

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10536
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6250
Build 10547: Bitcoin ABC Buildbot (legacy)
Build 10546: arc lint + arc unit

Event Timeline

nakihito created this revision.Jun 10 2019, 19:36
Owners added a reviewer: Restricted Owners Package.Jun 10 2019, 19:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 10 2019, 19:36
teamcity added a comment.Jun 10 2019, 19:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 10 2019, 19:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6250: Diff 9292.Jun 10 2019, 19:43
nakihito planned changes to this revision.Jun 10 2019, 20:56
nakihito requested review of this revision.EditedJun 10 2019, 22:39

Changes to bitcoin-tx.cpp removed here:
https://reviews.bitcoinabc.org/D540

Changes to wallet/rpcnestedtests.cpp removed here:
https://reviews.bitcoinabc.org/D1905#change-3IzUaXNi2dPc

wallet/crypter.cpp changes removed here:
https://reviews.bitcoinabc.org/D3119

wallet/rpcwallet.cpp changes are removed here:
https://reviews.bitcoinabc.org/rABC14aa545305a850354613718a953545682fa49890

Changes to wallet/walletdb.cpp are removed here:
https://reviews.bitcoinabc.org/D1106#change-QRUhUSaYIbHg Edit: the would-be-removed line is now used in the very next line
and
https://reviews.bitcoinabc.org/D301

jasonbcox accepted this revision.Jun 10 2019, 22:56
This revision is now accepted and ready to land.Jun 10 2019, 22:56
Closed by commit rABCdfc1e4deffce: Merge #10536: Remove unreachable or otherwise redundant code (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyJun 11 2019, 01:19
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCdfc1e4deffce: Merge #10536: Remove unreachable or otherwise redundant code.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGdfc1e4deffce: Merge #10536: Remove unreachable or otherwise redundant code.Sep 19 2019, 00:11

Revision Contents
Changeset List

PathSize
src/
wallet/
8 lines

Diff 9292

View Options

src/wallet/walletdb.cpp

Loading...