Fix rounding errors in calculation of minimum change size
ClosedPublic
Actions

Authored by deadalnix on Jun 11 2019, 18:18.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGd1dd4f3c22cf: Fix rounding errors in calculation of minimum change size
rABCd1dd4f3c22cf: Fix rounding errors in calculation of minimum change size

Summary

Backport of Core PR11145

The logging part of it is uneeded for us.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr11145

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6268
Build 10583: Bitcoin ABC Buildbot (legacy)
Build 10582: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 11 2019, 18:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 11 2019, 18:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6268: Diff 9325.Jun 11 2019, 18:25

deadalnix added a child revision: D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.Jun 12 2019, 12:48

Fabien accepted this revision.Jun 12 2019, 12:57

This revision is now accepted and ready to land.Jun 12 2019, 12:57

Closed by commit rABCd1dd4f3c22cf: Fix rounding errors in calculation of minimum change size (authored by Alex Morcos <morcos@chaincode.com>, committed by deadalnix). · Explain WhyJun 12 2019, 13:50

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCd1dd4f3c22cf: Fix rounding errors in calculation of minimum change size.

deadalnix added a commit: rSTAGINGd1dd4f3c22cf: Fix rounding errors in calculation of minimum change size.Sep 19 2019, 00:13

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

26 lines

Diff 9325

View Options

Fix rounding errors in calculation of minimum change sizeClosedPublicActions