Eliminate fee overpaying edge case when subtracting fee from recipients
ClosedPublic
Actions

Authored by deadalnix on Jun 11 2019, 23:56.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING7f206a919424: Eliminate fee overpaying edge case when subtracting fee from recipients
rABC7f206a919424: Eliminate fee overpaying edge case when subtracting fee from recipients

Summary

This is a backport of Core PR10942

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr10942

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6277
Build 10601: Bitcoin ABC Buildbot (legacy)
Build 10600: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 11 2019, 23:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 11 2019, 23:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6277: Diff 9336.Jun 12 2019, 00:02

jasonbcox accepted this revision.Jun 12 2019, 00:38

This revision is now accepted and ready to land.Jun 12 2019, 00:38

deadalnix added a child revision: D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.Jun 12 2019, 12:48

Closed by commit rABC7f206a919424: Eliminate fee overpaying edge case when subtracting fee from recipients (authored by Alex Morcos <morcos@chaincode.com>, committed by deadalnix). · Explain WhyJun 12 2019, 13:47

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC7f206a919424: Eliminate fee overpaying edge case when subtracting fee from recipients.

deadalnix added a commit: rSTAGING7f206a919424: Eliminate fee overpaying edge case when subtracting fee from recipients.Sep 19 2019, 00:13

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

14 lines

Diff 9336

View Options

Eliminate fee overpaying edge case when subtracting fee from recipientsClosedPublicActions