Page MenuHomePhabricator
Differential D330

Lint C files.
ClosedPublic
Actions

Authored by deadalnix on Jul 14 2017, 16:54.

Details

Reviewers
freetrader
sickpig
awemany
dagurval
Group Reviewers
Restricted Project
Commits
rSTAGINGcd309c8d55cb: Lint C files.
rABCcd309c8d55cb: Lint C files.
Summary

So far C file were excluded from linting. Not anymore.

Test Plan
arc lint

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lintc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 525
Build 525: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 14 2017, 16:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 14 2017, 16:54
kyuupichan requested changes to this revision.Jul 15 2017, 04:23
kyuupichan added inline comments.
src/crypto/ctaes/bench.c
4 ↗(On Diff #826)

What's this about? System headers should be included first. Should sys/time.h use <> brackets?

This revision now requires changes to proceed.Jul 15 2017, 04:23
deadalnix requested review of this revision.Jul 17 2017, 15:49
deadalnix edited edge metadata.
deadalnix added inline comments.
src/crypto/ctaes/bench.c
4 ↗(On Diff #826)

Yes it should but this is completely off topic.

deadalnix updated this revision to Diff 842.Jul 17 2017, 15:50

rebase

Harbormaster completed remote builds in B525: Diff 842.Jul 17 2017, 15:50
freetrader accepted this revision.Jul 17 2017, 20:42
deadalnix removed a reviewer: kyuupichan.Jul 18 2017, 11:30
This revision is now accepted and ready to land.Jul 18 2017, 11:30
Closed by commit rABCcd309c8d55cb: Lint C files. (authored by deadalnix, committed by deadalnix). · Explain WhyJul 18 2017, 11:30
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines
src/
crypto/
ctaes/
90 lines
146 lines
83 lines

Diff 842

View Options

.arclint

Loading...
View Options

src/crypto/ctaes/bench.c

Loading...
View Options

src/crypto/ctaes/ctaes.c

Loading...
View Options

src/crypto/ctaes/test.c

Loading...