Page MenuHomePhabricator
Differential D3352

Restore minRelayTxFee
ClosedPublic
Actions

Authored by deadalnix on Jun 16 2019, 22:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING4625244b514f: Restore minRelayTxFee
rABC4625244b514f: Restore minRelayTxFee
Summary

It was replaced by Config::GetMinFeePerKB, but this ended up intermingled with CWallet::minTxFee and the whole thing is a mess.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
configminfeeremove
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6374
Build 10795: Bitcoin ABC Buildbot (legacy)
Build 10794: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 16 2019, 22:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 16 2019, 22:53
teamcity added a comment.Jun 16 2019, 22:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6374: Diff 9486.Jun 16 2019, 23:02
teamcity added a comment.Jun 16 2019, 23:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D3353: Restore CWallet::minTxFee.Jun 17 2019, 00:49
Fabien requested changes to this revision.Jun 17 2019, 10:06
Fabien added a subscriber: Fabien.

One nit, looks good otherwise.

src/wallet/fees.cpp
34

Nit: wa removed to => was removed so

This revision now requires changes to proceed.Jun 17 2019, 10:06
deadalnix updated this revision to Diff 9494.Jun 17 2019, 15:39

Fix comment

teamcity added a comment.Jun 17 2019, 15:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 17 2019, 15:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6378: Diff 9494.Jun 17 2019, 15:46
Fabien accepted this revision.Jun 17 2019, 16:56
This revision is now accepted and ready to land.Jun 17 2019, 16:56
Closed by commit rABC4625244b514f: Restore minRelayTxFee (authored by deadalnix). · Explain WhyJun 17 2019, 23:46
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC4625244b514f: Restore minRelayTxFee.
deadalnix added a commit: rSTAGING4625244b514f: Restore minRelayTxFee.Sep 19 2019, 00:22

Revision Contents
Changeset List

PathSize
src/
12 lines
8 lines
6 lines
4 lines
policy/
1 line
rpc/
3 lines
test/
5 lines
2 lines
5 lines
2 lines
wallet/
4 lines
2 lines
3 lines

Diff 9486

View Options

src/config.h

Loading...
View Options

src/config.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/policy/policy.h

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/test/policyestimator_tests.cpp

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/fees.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...