Page MenuHomePhabricator
Differential D3375

Merge #10765: Tests: address placement should be deterministic by default
ClosedPublic
Actions

Authored by jasonbcox on Jun 21 2019, 00:23.

Details

Reviewers
deadalnix
markblundeberg
nakihito
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGce8a0839863a: Merge #10765: Tests: address placement should be deterministic by default
rABCce8a0839863a: Merge #10765: Tests: address placement should be deterministic by default
Summary

c5ebddd11 Tests: address placement should be deterministic by default (René Nyffenegger)

Pull request description:

Better version of wrong and closed pull request https://github.com/bitcoin/bitcoin/pull/10764

Tree-SHA512: dfda6ea4a9dd0f4c8b96212ad43a716ff1dddf115cd2712a2a7e42c97fc9494079c746906b39d880a9827c05d2b75c728afd4ca4519ce4d365f0dae0c4aec24c

Backport of Core PR10765

https://github.com/bitcoin/bitcoin/pull/10765/files

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 21 2019, 00:23
Herald added a reviewer: deadalnix. · View Herald TranscriptJun 21 2019, 00:23
jasonbcox planned changes to this revision.Jun 21 2019, 00:23
teamcity added a comment.Jun 21 2019, 00:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox updated this revision to Diff 9557.Jun 21 2019, 00:27

Fixed whitespace

teamcity added a comment.Jun 21 2019, 00:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 21 2019, 00:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6418: Diff 9556.Jun 21 2019, 00:29
Harbormaster completed remote builds in B6419: Diff 9557.Jun 21 2019, 00:37
teamcity added a comment.Jun 21 2019, 00:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg requested changes to this revision.Jun 21 2019, 13:59
markblundeberg added a subscriber: markblundeberg.
markblundeberg added inline comments.
src/test/addrman_tests.cpp
524 ↗(On Diff #9557)

what about this one?

557 ↗(On Diff #9557)

and this one?

615 ↗(On Diff #9557)

and this one?

This revision now requires changes to proceed.Jun 21 2019, 13:59
jasonbcox added inline comments.Jun 24 2019, 20:52
src/test/addrman_tests.cpp
524 ↗(On Diff #9557)

Interesting, despite these tests being backported out of order, these superfluous lines are still present in Core. I will clean them up them regardless.

jasonbcox updated this revision to Diff 9630.Jun 24 2019, 21:00

Rebase + remove related lines in other tests

teamcity added a comment.Jun 24 2019, 21:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jun 24 2019, 21:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6465: Diff 9630.Jun 24 2019, 21:06
nakihito accepted this revision.Jun 24 2019, 21:46
Fabien accepted this revision.Jun 25 2019, 06:13
markblundeberg accepted this revision.Jun 28 2019, 01:41

Ah! Sorry for holding this up, I forgot about it and didn't realize it was waiting on me.

This revision is now accepted and ready to land.Jun 28 2019, 01:41
Closed by commit rABCce8a0839863a: Merge #10765: Tests: address placement should be deterministic by default (authored by jasonbcox). · Explain WhyJun 28 2019, 15:52
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCce8a0839863a: Merge #10765: Tests: address placement should be deterministic by default.
jasonbcox added a commit: rSTAGINGce8a0839863a: Merge #10765: Tests: address placement should be deterministic by default.Sep 19 2019, 00:42
PiRK added a subscriber: PiRK.Oct 12 2020, 09:45

https://reviews.bitcoinabc.org/D3375#80618

This takes care of PR16422 in addition of PR10765. I just now tried to cherry-pick the commit, and got an empty commit.

Revision Contents
Changeset List

PathSize
src/
test/
51 lines

Diff 9772

View Options

src/test/addrman_tests.cpp

Loading...