Page MenuHomePhabricator

Merge #13726: Utils and libraries: Removes the boost/algorithm/string/join dependency
ClosedPublic

Authored by markblundeberg on Jun 21 2019, 17:48.

Details

Summary

PR13726 backport https://github.com/bitcoin/bitcoin/pull/13726/files
5f019d5354 Removes the boost/algorithm/string/join dependency (251)

Pull request description:

This commit removes the `boost/algorithm/string/join` dependency from the project by replacing `boost::algorithm::join` with the helper function proposed by @MarcoFalke in https://github.com/bitcoin/bitcoin/pull/13726#discussion_r204159967

Backporter notes:

  • One line missing due to prior removal of versionbits logic.
Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6432
Build 10911: Bitcoin ABC Buildbot (legacy)
Build 10910: arc lint + arc unit

Event Timeline

This is mostly a nominal backport -- these parts will likely be removed anyway. (see D2788)

somehow the include didn't get removed on first pass

jasonbcox requested changes to this revision.Jun 21 2019, 21:40
jasonbcox added inline comments.
src/validation.cpp
2111

brackets

This revision now requires changes to proceed.Jun 21 2019, 21:40
This revision is now accepted and ready to land.Jun 24 2019, 18:30