Page MenuHomePhabricator

Merge #13622: Remove mapRequest tracking that just effects Qt display.
ClosedPublic

Authored by markblundeberg on Jun 30 2019, 17:42.

Details

Summary

PR13622 backport https://github.com/bitcoin/bitcoin/pull/13622/files
beef7ec4be725beea870a2da510d2817487601ec Remove useless mapRequest tracking that just effects Qt display. (Matt Corallo)

Pull request description:

I thought we had removed this a long time ago, TBH, its really
confusing feedback to users that we display whether a tx was
broadcast to immediate neighbor nodes, given that has little
indication of whether the tx propagated very far.
Test Plan

make check
test_bitcoin-qt
Run bitcoin-qt without any peers (connect=0 listen=0) and make a tx; right
click on tx and open full details, observe it doesn't say "has not been
successfully broadcast".

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6561
Build 11169: Bitcoin ABC Buildbot (legacy)
Build 11168: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jun 30 2019, 20:44