Page MenuHomePhabricator

Merge #10912: [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp
ClosedPublic

Authored by markblundeberg on Jun 30 2019, 19:59.

Details

Summary

PR10912 backport https://github.com/bitcoin/bitcoin/pull/10912/files
065039d [tests] Fix incorrect memory_cleanse(…) call in crypto_tests.cpp (practicalswift)

Pull request description:

`chKey` and `chIV` are pointers, not arrays :-)

Probably the result of copy-pasting of old code where the code was operating on arrays instead of pointers.

If I'm reading the code correctly the absence/presence of these `memory_cleanse(…)` calls won't alter the outcome of the test in question (`TestPassphraseSingle`) even if fixed. Therefore removing.
Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6563
Build 11173: Bitcoin ABC Buildbot (legacy)
Build 11172: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jun 30 2019, 20:46