Page MenuHomePhabricator
Differential D3541

Merge #10313: [Consensus] Add constant for maximum stack size
ClosedPublic
Actions

Authored by nakihito on Jul 3 2019, 19:39.

Details

Reviewers
deadalnix
Fabien
jasonbcox
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING74c90dd74fcf: Merge #10313: [Consensus] Add constant for maximum stack size
rABC74c90dd74fcf: Merge #10313: [Consensus] Add constant for maximum stack size
Summary

cb184b3 Add constant for maximum stack size (Gregory Sanders)

Tree-SHA512: 0ec4a28552a6eee7fba8c69278f63c61f095e4ba06cb34456bd0162cd702370d10cca621ae1797a0d5e62fb39814cbb8245d3a7adc007ca39dab7a49cbc925dc

Backport of Core PR10313
https://github.com/bitcoin/bitcoin/pull/10313/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jul 3 2019, 19:39
Owners added a reviewer: Restricted Owners Package.Jul 3 2019, 19:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 3 2019, 19:39
teamcity added a comment.Jul 3 2019, 19:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 3 2019, 19:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6657: Diff 9972.Jul 3 2019, 19:50
markblundeberg accepted this revision as: markblundeberg.Jul 3 2019, 19:54

Even something so simple makes me nervous but note there are tests for STACK_SIZE error (and for max-sized stacks) in script_tests.json.

deadalnix accepted this revision.Jul 3 2019, 23:37
This revision is now accepted and ready to land.Jul 3 2019, 23:37
Closed by commit rABC74c90dd74fcf: Merge #10313: [Consensus] Add constant for maximum stack size (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyJul 5 2019, 17:53
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC74c90dd74fcf: Merge #10313: [Consensus] Add constant for maximum stack size.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING74c90dd74fcf: Merge #10313: [Consensus] Add constant for maximum stack size.Sep 19 2019, 00:58

Revision Contents
Changeset List

PathSize
src/
script/
2 lines
3 lines

Diff 10017

View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/script.h

Loading...