Page MenuHomePhabricator
Differential D3543

Always use cashaddr for dummy addresses in the GUI
ClosedPublic
Actions

Authored by deadalnix on Jul 4 2019, 12:06.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGINGbcde96f2a506: Always use cashaddr for dummy addresses in the GUI
rABCbcde96f2a506: Always use cashaddr for dummy addresses in the GUI
Summary

As per title.

Test Plan

Updated unittests to reflect the change.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
dummyaddrqt
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6659
Build 11365: Bitcoin ABC Buildbot (legacy)
Build 11364: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 4 2019, 12:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2019, 12:06
teamcity added a comment.Jul 4 2019, 12:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 4 2019, 12:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6659: Diff 9974.Jul 4 2019, 12:13
deadalnix added a child revision: D3550: Remove EncodeDestination's overload relying on global state.Jul 4 2019, 17:25
deadalnix added a child revision: D3551: Default to cashaddr in most of the Qt API.Jul 4 2019, 19:13
markblundeberg accepted this revision.Jul 5 2019, 16:18
This revision is now accepted and ready to land.Jul 5 2019, 16:18
Closed by commit rABCbcde96f2a506: Always use cashaddr for dummy addresses in the GUI (authored by deadalnix). · Explain WhyJul 6 2019, 14:05
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCbcde96f2a506: Always use cashaddr for dummy addresses in the GUI.
deadalnix added a commit: rSTAGINGbcde96f2a506: Always use cashaddr for dummy addresses in the GUI.Sep 19 2019, 00:59

Revision Contents
Changeset List

PathSize
src/
qt/
5 lines
12 lines
test/
10 lines
test/
1 line

Diff 9974

View Options

src/qt/guiutil.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/test/guiutiltests.cpp

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...