Page MenuHomePhabricator

Change all python files to use Python3
ClosedPublic

Authored by Fabien on Jul 5 2019, 09:21.

Details

Summary
It's easier for maintainers if all python tools/scripts support only a
single version of Python. There are only a few scripts that aren't
explicitly python3 at this point, so this PR changes those remaining
scripts to explicitly require python3.

Backport of core PR11881
https://github.com/bitcoin/bitcoin/pull/11881/files

Depends on D3555

Test Plan

Should execute with no python error from build dir:

../test/lint/check-doc.py
../contrib/devtools/optimize-pngs.py
../contrib/devtools/security-check.py src/bitcoind
../contrib/devtools/symbol-check.py src/bitcoind
../contrib/testgen/gen_base58_test_vectors.py valid 10 >

/tmp/test.json

../share/rpcauth/rpcauth.py foo

Should execute with no python error from project root:

./contrib/devtools/update-translations.py

Should execute with no python error from src/:

../share/qt/extract_strings_qt.py ../src/init.cpp

macdeploy/ scripts not tested

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11881
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6674
Build 11395: Bitcoin ABC Buildbot (legacy)
Build 11394: arc lint + arc unit