Page MenuHomePhabricator
Differential D3619

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.
ClosedPublic
Actions

Authored by deadalnix on Jul 9 2019, 19:49.

Details

Reviewers
Fabien
jasonbcox
markblundeberg
nakihito
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGd09a95d5f43d: Merge #9544: [trivial] Add end of namespace comments. Improve consistency.
rABCd09a95d5f43d: Merge #9544: [trivial] Add end of namespace comments. Improve consistency.
Summary

5a9b508 [trivial] Add end of namespace comments (practicalswift)

Tree-SHA512: 92b0fcae4d1d3f4da9e97569ae84ef2d6e09625a5815cd0e5f0eb6dd2ecba9852fa85c184c5ae9de5117050330ce995e9867b451fa8cd5512169025990541a2b

Backport of Core PR9544
https://github.com/bitcoin/bitcoin/pull/9544/files

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR9544
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6775
Build 11597: Bitcoin ABC Buildbot (legacy)
Build 11596: arc lint + arc unit

Event Timeline

nakihito created this revision.Jul 9 2019, 19:49
Owners added a reviewer: Restricted Owners Package.Jul 9 2019, 19:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 9 2019, 19:49
nakihito planned changes to this revision.Jul 9 2019, 19:49
teamcity added a comment.Jul 9 2019, 19:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 9 2019, 19:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6775: Diff 10157.Jul 9 2019, 19:57
nakihito requested review of this revision.Jul 10 2019, 22:06

base58.cpp change wes made in D624 and then the code was moved to a different file in D3577.
The majority of other changes were made in D873.

deadalnix requested changes to this revision.Jul 10 2019, 23:56

There is a tool that can do this automatically and exaustively. Use it.

This revision now requires changes to proceed.Jul 10 2019, 23:56
deadalnix commandeered this revision.Jul 14 2019, 17:49
deadalnix edited reviewers, added: nakihito; removed: deadalnix.
deadalnix updated this revision to Diff 10288.Jul 14 2019, 17:53

Update cland-format to enforce the new style

teamcity added a comment.Jul 14 2019, 17:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 14 2019, 18:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6858: Diff 10288.Jul 14 2019, 18:00
nakihito accepted this revision.Jul 15 2019, 22:39
jasonbcox accepted this revision.Jul 16 2019, 03:01
This revision is now accepted and ready to land.Jul 16 2019, 03:01
Closed by commit rABCd09a95d5f43d: Merge #9544: [trivial] Add end of namespace comments. Improve consistency. (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by deadalnix). · Explain WhyJul 16 2019, 12:59
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCd09a95d5f43d: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..
deadalnix added a commit: rSTAGINGd09a95d5f43d: Merge #9544: [trivial] Add end of namespace comments. Improve consistency..Sep 19 2019, 01:17

Revision Contents
Changeset List

PathSize
doc/
17 lines
src/
bench/
2 lines

Diff 10157

View Options

doc/developer-notes.md

Loading...
View Options

src/bench/checkblock.cpp

Loading...