convert C-style (void) parameter lists to C++ style ()
ClosedPublic
Actions

Authored by deadalnix on Jul 24 2019, 13:53.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGf79241a33120: convert C-style (void) parameter lists to C++ style ()
rABCf79241a33120: convert C-style (void) parameter lists to C++ style ()

Summary

This is similar to Core PR14214 but I redid it by hand to not deal with merge conficts.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr14214

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6938
Build 11923: Bitcoin ABC Buildbot (legacy)
Build 11922: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 24 2019, 13:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 24 2019, 13:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B6938: Diff 10428.Jul 24 2019, 14:02

jasonbcox accepted this revision.Jul 24 2019, 20:06

This revision is now accepted and ready to land.Jul 24 2019, 20:06

Closed by commit rABCf79241a33120: convert C-style (void) parameter lists to C++ style () (authored by deadalnix). · Explain WhyJul 24 2019, 23:27

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCf79241a33120: convert C-style (void) parameter lists to C++ style ().

deadalnix mentioned this in D3953: Merge #12618: Set SCHED_BATCH priority on the loadblk thread..Aug 28 2019, 14:13

Fabien mentioned this in D3984: [LINTER] Enforce using C++ style for void parameters.Sep 3 2019, 10:28

Fabien mentioned this in rABC8eb343852006: [LINTER] Enforce using C++ style for void parameters.Sep 8 2019, 10:00

deadalnix added a commit: rSTAGINGf79241a33120: convert C-style (void) parameter lists to C++ style ().Sep 19 2019, 01:25

Fabien mentioned this in rSTAGING8eb343852006: [LINTER] Enforce using C++ style for void parameters.Sep 19 2019, 02:11

Revision Contents
Changeset List

Path

Size

src/

4 lines

4 lines

2 lines

2 lines

qt/

bitcoin.cpp

2 lines

macnotificationhandler.h

2 lines

macnotificationhandler.mm

2 lines

rpcconsole.cpp

7 lines

rpc/

server.h

4 lines

server.cpp

2 lines

test/

crypto_tests.cpp

2 lines

ui_interface.h

2 lines

validation.cpp

2 lines

wallet/

test/

coinselector_tests.cpp

2 lines

Diff 10428

View Options

src/httprpc.cpp

View Options

src/httpserver.h

View Options

src/httpserver.cpp

View Options

src/init.cpp

View Options

src/qt/bitcoin.cpp

View Options

src/qt/macnotificationhandler.h

View Options

src/qt/macnotificationhandler.mm

View Options

src/qt/rpcconsole.cpp

View Options

src/rpc/server.h

View Options

src/rpc/server.cpp

View Options

src/test/crypto_tests.cpp

View Options

src/ui_interface.h

View Options

src/validation.cpp

View Options

src/wallet/test/coinselector_tests.cpp

convert C-style (void) parameter lists to C++ style ()ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10428

src/httprpc.cpp

src/httpserver.h

src/httpserver.cpp

src/init.cpp

src/qt/bitcoin.cpp

src/qt/macnotificationhandler.h

src/qt/macnotificationhandler.mm

src/qt/rpcconsole.cpp

src/rpc/server.h

src/rpc/server.cpp

src/test/crypto_tests.cpp

src/ui_interface.h

src/validation.cpp

src/wallet/test/coinselector_tests.cpp

convert C-style (void) parameter lists to C++ style ()
ClosedPublic
Actions

Revision Contents
Changeset List