Page MenuHomePhabricator
Differential D3833

Merge #11395: Qt: Enable searching by transaction id
ClosedPublic
Actions

Authored by nakihito on Aug 8 2019, 23:57.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING524ce61e18f2: Merge #11395: Qt: Enable searching by transaction id
rABC524ce61e18f2: Merge #11395: Qt: Enable searching by transaction id
Summary

eac2abca0 Qt: Enable searching by transaction id (Luke Dashjr)
c407c61c5 Qt: Avoid invalidating the search filter, when it doesn't really change (Luke Dashjr)
b1f634242 Qt: Rename confusingly-named "address prefix" to "search string" (Luke Dashjr)

Pull request description:

Tree-SHA512: 1c67037d19689fbaff21d15ed7848ac86188e5de34728312e1f9758dada759cab50d913a5bc09e413ecaa3e07557cf253809b95b5637ff79f2e3cf24d86dd3ed

Backport of Core PR11395
https://github.com/bitcoin/bitcoin/pull/11395/

Depends on D3832

Test Plan
make check
./bitcoin-qt -> transactions -> enter transaction id to filter by

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Aug 8 2019, 23:57
Owners added a reviewer: Restricted Owners Package.Aug 8 2019, 23:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 8 2019, 23:57
nakihito planned changes to this revision.Aug 8 2019, 23:57
teamcity added a comment.Aug 9 2019, 00:06

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 9 2019, 00:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7091: Diff 10692.Aug 9 2019, 00:18
nakihito added a child revision: D3812: Merge #12621: Avoid querying unnecessary model data when filtering transactions.Aug 9 2019, 01:35
nakihito updated this revision to Diff 10744.Aug 12 2019, 22:59

Fixed formatting.

teamcity added a comment.Aug 12 2019, 22:59

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 12 2019, 22:59

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 12 2019, 23:07

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7126: Diff 10744!Aug 12 2019, 23:08
teamcity added a comment.Aug 12 2019, 23:20

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 12 2019, 23:35

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Aug 13 2019, 01:18

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 13 2019, 01:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 13 2019, 01:31

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7126: Diff 10744.Aug 13 2019, 01:31
Fabien accepted this revision.Aug 13 2019, 07:01
This revision is now accepted and ready to land.Aug 13 2019, 07:01
Closed by commit rABC524ce61e18f2: Merge #11395: Qt: Enable searching by transaction id (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by nakihito). · Explain WhyAug 13 2019, 18:05
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC524ce61e18f2: Merge #11395: Qt: Enable searching by transaction id.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING524ce61e18f2: Merge #11395: Qt: Enable searching by transaction id.Sep 19 2019, 01:48

Revision Contents
Changeset List

Diff 10764

View Options

src/qt/transactionfilterproxy.h

Loading...
View Options

src/qt/transactionfilterproxy.cpp

Loading...
View Options

src/qt/transactionview.h

Loading...
View Options

src/qt/transactionview.cpp

Loading...