Page MenuHomePhabricator
Differential D3889

Merge #12803: Make BaseSignatureCreator a pure interface
ClosedPublic
Actions

Authored by nakihito on Aug 15 2019, 22:58.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGa79f706a34fe: Merge #12803: Make BaseSignatureCreator a pure interface
rABCa79f706a34fe: Merge #12803: Make BaseSignatureCreator a pure interface
Summary

be67831 Make DummySignatureCreator a singleton (Pieter Wuille)
190b8d2 Make BaseSignatureCreator a pure interface (Pieter Wuille)

Pull request description:

  • Removes the m_provider field from BaseSignatureCreator. Instead both a SigningProvider (which provides keys and scripts) and a BaseSignatureCreator (which implements the transaction-specific (or other) signing logic) are passed into and down in ProduceSignature, making the two concepts orthogonal.
  • Makes BaseSignatureCreator a pure interface without constructor, making it easier to implement new derivations of it (for example for message signing).
  • As DummySignatureCreator now becomes a stateless object, turn it into a singleton DUMMY_SIGNATURE_CREATOR.

Tree-SHA512: 5f1f4512e4ea7d02a31df7b9ede55008efa716c5b74a2630ca1c2fc6599584d8bf5f5641487266127f4b3788033803539fbd22b03ef1219c83c10da2d3da3dcd

Backport of Core PR12803
https://github.com/bitcoin/bitcoin/pull/12803/

Depends on D3888

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12803
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7169
Build 12383: Bitcoin ABC Buildbot (legacy)
Build 12382: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 15 2019, 22:58
Owners added a reviewer: Restricted Owners Package.Aug 15 2019, 22:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 15 2019, 22:59
teamcity added a comment.Aug 15 2019, 22:59

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7169: Diff 10822.Aug 15 2019, 23:06
teamcity added a comment.Aug 15 2019, 23:06

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien accepted this revision.Aug 20 2019, 08:57
This revision is now accepted and ready to land.Aug 20 2019, 08:57
Closed by commit rABCa79f706a34fe: Merge #12803: Make BaseSignatureCreator a pure interface (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyAug 20 2019, 18:45
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCa79f706a34fe: Merge #12803: Make BaseSignatureCreator a pure interface.
Fabien mentioned this in D3985: Add missing override keyword to DummySignatureCreator::CreateSig().Sep 3 2019, 13:47
Fabien mentioned this in rABC8f5f90aa1296: Add missing override keyword to DummySignatureCreator::CreateSig().Sep 4 2019, 15:36
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGa79f706a34fe: Merge #12803: Make BaseSignatureCreator a pure interface.Sep 19 2019, 01:57
Fabien mentioned this in rSTAGING8f5f90aa1296: Add missing override keyword to DummySignatureCreator::CreateSig().Sep 19 2019, 02:07
markblundeberg mentioned this in D4912: Reintroduce IsSolvable.Jan 12 2020, 12:48
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABC9dda12ee9286: Reintroduce IsSolvable.Jan 13 2020, 00:59
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGING9dda12ee9286: Reintroduce IsSolvable.Apr 7 2020, 22:23

Revision Contents
Changeset List

PathSize
src/
5 lines
rpc/
5 lines
script/
2 lines
35 lines
99 lines
test/
16 lines
wallet/
17 lines

Diff 10822

View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/script/ismine.cpp

Loading...
View Options

src/script/sign.h

Loading...
View Options

src/script/sign.cpp

Loading...
View Options

src/test/txvalidationcache_tests.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...